chore: improve test filtering to use mocha hooks #3095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durran
previously requested changes
Jan 7, 2022
nbbeeken
force-pushed
the
chore/test-filter-with-hook
branch
from
d407b9f
to
b6d9090
Compare
nbbeeken
commented
Jan 7, 2022
test/integration/client-side-encryption/client_side_encryption.prose.test.js
Outdated
Show resolved
Hide resolved
baileympearson
requested changes
Jan 7, 2022
test/integration/client-side-encryption/client_side_encryption.prose.test.js
Show resolved
Hide resolved
baileympearson
previously approved these changes
Jan 7, 2022
dariakp
requested changes
Jan 7, 2022
test/integration/client-side-encryption/client_side_encryption.prose.test.js
Outdated
Show resolved
Hide resolved
|
@nbbeeken One more question, you mention the legacy spec runner follow up work - do we already have a ticket for that? |
Co-authored-by: Daria Pardue <daria.pardue@mongodb.com>
Yep! here: https://jira.mongodb.org/browse/NODE-3817 |
- Added type defintions that describe our metadata overloads, new tsconfig imports this, it makes it so vscode will auto discover the extensions - Added skipReason to the unified runner
dariakp
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Use a beforeEach hook to run test filters.
Also: remove docker stuff, move the sdam_viz tool to etc with out other helper scripts, corrected small type issue in unified test schema, enabled test sorting
What is the motivation for this change?
LOG_FILTER_REASONcan be enabled to view which filter made a test skipFollow up work
Our legacy spec runner still "multiplies" the tests by runOn requirement and then relies on the filter to skip the ones that don't apply. Fixing this would drastically reduce the test count without actually removing tests.
Now that we have a standardized runOn requirement documented in the unified format, it would be nice to refactor our filtering metadata to match that, and reuse the logic in topologySatisfies in the unified runner.
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>