test(NODE-3860): improve skipReason reporting for disabled 'auth' tests #3137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
force-pushed
the
NODE-3860-remove-metadata-skip-reason
branch
from
9970a7b
to
ed88651
Compare
dariakp
reviewed
Feb 9, 2022
dariakp
approved these changes
Feb 10, 2022
nbbeeken
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
This PR cleans up the
skipReasonlogic added in #3121. By including the skipReason and the filter statusauth: disabledin the metadata for tests that fail becauseauthwas enabled, in cases where the test would not have run due to other requirements, we report the skip reason being thatauthwas enabled rather than the actual skip reason for the test.This PR also fixes the broken AWS tests.
Is there new documentation needed for these changes?
No.
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>