Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(NODE-3719): spec compliance review wrap up #3145

Merged
merged 20 commits into from
Feb 16, 2022

Conversation

dariakp
Copy link
Contributor

@dariakp dariakp commented Feb 14, 2022

Description

NODE-3719

What is changing?

A few things:

  • unskipping working csfle automated spec tests
  • some reordering and annotating of the fle prose tests
  • adding the missing tls options fle prose test
  • fix no auth test build variants to include fle (otherwise the fle tests get skipped entirely, which is particularly bad, because the csfle tests must run on auth and no auth configs per the spec)
  • make sure the csfle filter does not skip silently
  • make sure manual tests do not pass if no tests run (add the same failZero flag to the manual mocha config as in our main config)
Is there new documentation needed for these changes?

N/A

What is the motivation for this change?

Spec compliance review

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

.evergreen/run-tests.sh Outdated Show resolved Hide resolved
@baileympearson baileympearson merged commit aa069f1 into main Feb 16, 2022
@baileympearson baileympearson deleted the NODE-3719/fle-spec-review-cleanup branch February 16, 2022 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants