test: ensure our enums are types and values #3146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durran
previously approved these changes
Feb 15, 2022
dariakp
added
Blocked
nbbeeken
force-pushed
the
test/enum-types
branch
from
ac220e8
to
db652e3
Compare
durran
previously approved these changes
Feb 18, 2022
dariakp
previously approved these changes
Feb 18, 2022
baileympearson
previously approved these changes
Feb 18, 2022
nbbeeken
dismissed stale reviews from baileympearson, dariakp, and durran
via
154a287
dariakp
approved these changes
Feb 18, 2022
durran
approved these changes
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
I've added tests that make sure the type annotation and enum values are equal.
Inspired by a conversation on #3131
What is the motivation for this change?
By using
Object.values(x)are type tests will ensure that we continue to export an actual runtime value.And then also the expectType assertion checks to make sure that X is a typescript type.
This will prevent any regression around our choice of doing manual type augmentation for Enums.
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>