-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(NODE-4165): sync maxConnecting spec tests and update runner #3239
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
requesting changes for visibility but I really only have a couple questions.
...integration/connection-monitoring-and-pooling/connection_monitoring_and_pooling.spec.test.ts
Show resolved
Hide resolved
...integration/connection-monitoring-and-pooling/connection_monitoring_and_pooling.spec.test.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about using the test names like so?
...integration/connection-monitoring-and-pooling/connection_monitoring_and_pooling.spec.test.ts
Show resolved
Hide resolved
...integration/connection-monitoring-and-pooling/connection_monitoring_and_pooling.spec.test.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed offline we can address cleanups in follow up
Description
NODE-4165
What is changing?
ready
operation, which is a no-op until pool pausing is implemented (no need for TODO, since the new tests for pool pausing will fail if this continues to be a no-op, and it does not play any role in the current tests)Is there new documentation needed for these changes?
No
What is the motivation for this change?
Paving the way for the maxConnecting feature
Double check the following
npm run check:lint
script<type>(NODE-xxxx)<!>: <description>