Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(NODE-4165): sync maxConnecting spec tests and update runner #3239

Merged
merged 12 commits into from
May 10, 2022

Conversation

dariakp
Copy link
Contributor

@dariakp dariakp commented May 9, 2022

Description

NODE-4165

What is changing?

  • Synced maxConnecting tests including changes from NODE-4165, NODE-3666, and NODE-2983.
  • CMAP unit tests now run as integration tests, the maxConnecting tests are skipped for now, but they can be seen failing in a uniform manner here
  • The runner has been updated with new TypeScript types for integration tests and also has a new ready operation, which is a no-op until pool pausing is implemented (no need for TODO, since the new tests for pool pausing will fail if this continues to be a no-op, and it does not play any role in the current tests)
Is there new documentation needed for these changes?

No

What is the motivation for this change?

Paving the way for the maxConnecting feature

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@dariakp dariakp marked this pull request as ready for review May 9, 2022 17:40
Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requesting changes for visibility but I really only have a couple questions.

@dariakp dariakp added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label May 10, 2022
@baileympearson baileympearson added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels May 10, 2022
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about using the test names like so?

Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline we can address cleanups in follow up

@dariakp dariakp merged commit 15f8870 into main May 10, 2022
@dariakp dariakp deleted the NODE-4165/maxConnecting-spec-tests branch May 10, 2022 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
3 participants