Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NODE-4521)!: remove custom promise library support #3498

Merged
merged 1 commit into from
Dec 22, 2022
Merged

feat(NODE-4521)!: remove custom promise library support #3498

merged 1 commit into from
Dec 22, 2022

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Dec 21, 2022 •
edited by durran
Loading

Description

What is changing?

  • Removes "Promise" export (which exposed .set for setting a global promise lib)
  • Removes promiseLibrary client option, which also set the global promise lib
  • Removes relevant tests, and uninstalls bluebird from dev deps

What is the motivation for this change?

Improvements with async/await syntax

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken force-pushed the NODE-4521-rm-support-for-custom-promises branch from 8e4b700 to e699d6f Compare December 21, 2022 19:00
@nbbeeken nbbeeken force-pushed the NODE-4521-rm-support-for-custom-promises branch from e699d6f to a871c09 Compare December 21, 2022 19:32
@nbbeeken nbbeeken marked this pull request as ready for review December 21, 2022 20:09
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Dec 22, 2022
@durran
Copy link
Member

durran commented Dec 22, 2022

Yay it's all gone!

@durran durran merged commit af36ebb into main Dec 22, 2022
@durran durran deleted the NODE-4521-rm-support-for-custom-promises branch December 22, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durran durran durran approved these changes

Assignees
No one assigned
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Milestone
No milestone
2 participants
@nbbeeken @durran