feat(NODE-5008): add zstd and kerberos to peer deps #3691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durran
force-pushed
the
NODE-5008
branch
3 times, most recently
from
45b0b18
to
d465af9
Compare
durran
added
the
Primary Review
baileympearson
requested changes
Jun 2, 2023
baileympearson
approved these changes
Jun 6, 2023
This was referenced Jun 8, 2023
malikj2000
pushed a commit
that referenced
this pull request
Jun 29, 2023
5 tasks
This was referenced Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds zstd and kerberos to peer dependencies.
What is changing?
Sets @mongodb-js/zstd and kerberos in the peer dependencies to their latest versions and sets them as optional.
Release Highlight
Zstd and Kerberos are now optional peer dependencies
This allows users who do not use these features to not have them installed. Users who do use these feature will now have them lazy loaded upon first use.
Is there new documentation needed for these changes?
None
What is the motivation for this change?
NODE-5008
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript