Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NODE-5590): deprecate GridFS fields #3905

Merged
merged 2 commits into from
Oct 31, 2023
Merged

feat(NODE-5590): deprecate GridFS fields #3905

merged 2 commits into from
Oct 31, 2023

Conversation

alenakhineika
Copy link
Contributor

@alenakhineika alenakhineika commented Oct 30, 2023 •
edited by nbbeeken

Description

Deprecate unused GridFS fields.

What is changing?

Deprecates contentType and aliases options.

Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-5590

Release Highlight

GridFS fields deprecated

The GridFS contentType and aliases options are deprecated. According to the GridFS spec, applications wishing to store contentType and aliases should add a corresponding field to the metadata document instead.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@alenakhineika alenakhineika marked this pull request as ready for review October 30, 2023 17:22
@W-A-James W-A-James self-assigned this Oct 31, 2023
W-A-James
W-A-James requested changes Oct 31, 2023
View reviewed changes
src/gridfs/download.ts Outdated Show resolved Hide resolved
src/gridfs/download.ts Outdated Show resolved Hide resolved
@W-A-James W-A-James added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Oct 31, 2023
@W-A-James W-A-James added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Oct 31, 2023
@W-A-James W-A-James merged commit d2225da into main Oct 31, 2023
25 checks passed
@W-A-James W-A-James deleted the NODE-5590-deprecate-gridfs-fields branch October 31, 2023 18:06
@github-actions github-actions bot mentioned this pull request Oct 31, 2023
Merged
@alenakhineika alenakhineika removed the Team Review Needs review from team label Nov 1, 2023
@github-actions github-actions bot mentioned this pull request Dec 11, 2023
Open
@mnathsnyk mnathsnyk mentioned this pull request Mar 15, 2024
Open
@akanchhaS akanchhaS mentioned this pull request May 18, 2024
Open
@lydmoon lydmoon mentioned this pull request May 19, 2024
Open
@lryanle lryanle mentioned this pull request May 21, 2024
Open
@baby636 baby636 mentioned this pull request May 21, 2024
Open
@IdrizMirena IdrizMirena mentioned this pull request May 22, 2024
Open
@mkusztal mkusztal mentioned this pull request May 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durran durran durran approved these changes

@W-A-James W-A-James W-A-James approved these changes

Assignees

@W-A-James W-A-James

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@alenakhineika @durran @W-A-James