Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-5709): bump mongodb-connection-string-url to 3.0.0 #3909

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

addaleax
Copy link
Contributor

@addaleax addaleax commented Nov 2, 2023

This includes a solution for the deprecation warning in NODE-5709 by bumping whatwg-url. The major version bump is only because the new Node.js version minimum supported by that whatwg-url version is Node.js 16.

Description

What is changing?

Is there new documentation needed for these changes?

What is the motivation for this change?

Release Highlight

Fill in title or leave empty for no highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

This includes a solution for the deprecation warning in NODE-5709
by bumping whatwg-url. The major version bump is only because the
new Node.js version minimum supported by that whatwg-url version
is Node.js 16.
Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@addaleax
Copy link
Contributor Author

addaleax commented Nov 2, 2023

@durran thanks, done! :)

@addaleax addaleax requested a review from durran November 2, 2023 16:31
@durran durran self-assigned this Nov 2, 2023
@durran durran added Primary Review In Review with primary reviewer, not yet ready for team's eyes Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
3 participants