Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to edit tags in settings #6760

Merged
merged 13 commits into from
Nov 6, 2023

Conversation

khalilJayab
Copy link

Hi,
This pull request addresses issue #6172 , which was related to the inability to rename tags in the settings. With this fix, users can now easily edit the name of existing tags in the settings section.

Untitled

Thanks

PART OF GTC OPEN SOURCE INTIATIVE

@khalilJayab khalilJayab changed the title feat: change tags in settings feat: allow to edit tags in settings Jul 19, 2023
Copy link

@kniziol kniziol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some suggestions

app/Http/Controllers/SettingsController.php Outdated Show resolved Hide resolved
resources/views/settings/tags.blade.php Outdated Show resolved Hide resolved
resources/views/settings/tags.blade.php Outdated Show resolved Hide resolved
khalilJayab and others added 3 commits October 5, 2023 14:54
Co-authored-by: Krzysztof Nizioł <kniziol@gmail.com>
Co-authored-by: Krzysztof Nizioł <kniziol@gmail.com>
Co-authored-by: Krzysztof Nizioł <kniziol@gmail.com>
@khalilJayab
Copy link
Author

Done, thanks

Co-authored-by: Krzysztof Nizioł <kniziol@gmail.com>
@asbiin asbiin added the reviewed label Nov 1, 2023
@asbiin asbiin merged commit bdffa9b into monicahq:4.x Nov 6, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants