fix: misc bugfixes to reminders #6931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updating an existing reminder no longer deletes the user's notification channels - Finishing the setup of a Telegram connection now triggers a scheduling of the user's notifications, making behavior consistent with how email verification works
|
|
evanlihou
commented
Oct 14, 2023
tests/Unit/Domains/Contact/ManageReminders/Services/UpdateContactReminderTest.php
Outdated
Show resolved
Hide resolved
|
@djaiss @asbiin Thanks for all the work you do on this project! The issue that I opened for these bugs got closed, so I figured I'd try to implement a fix on my own. The combination of these two issues made the experience of using Telegram reminders in Chandler very frustrating. Please review this small PR at your earliest convenience 🙂 |
asbiin
requested changes
Oct 31, 2023
tests/Unit/Domains/Contact/ManageReminders/Services/UpdateContactReminderTest.php
Outdated
Show resolved
Hide resolved
…actReminderTest.php Co-authored-by: Alexis Saettler <alexis@saettler.org>
asbiin
approved these changes
Nov 1, 2023
|
🎉 This PR is included in version 5.0.0-beta.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been about 7 years since I've touched any code that uses Laravel, happy to make any updates you feel would improve the quality of this PR 🙂
Fixes #6776