Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong URL in email (containing localhost) #7168

Open
3 tasks done
chevdor opened this issue Feb 26, 2024 · 1 comment
Open
3 tasks done

Wrong URL in email (containing localhost) #7168

chevdor opened this issue Feb 26, 2024 · 1 comment
Labels

Comments

@chevdor
Copy link

chevdor commented Feb 26, 2024

⚠️ This issue respects the following points: ⚠️

  • This is a bug, not a question or a configuration/webserver/proxy issue.
  • This issue is not already reported on Github (I've searched it).
  • I agree to follow Monica's Code of Conduct.

Bug description

Wrong URL in email (containing localhost)

Steps to reproduce

  1. Setup APP_URL. ie APP_URL: monica.mydomain.com
  2. Get a reminder email
  3. See the URL in the email, it will be https://localhost/monica.mydomain.com/people/<...> instead of https://monica.mydomain.com/people/<...>

Expected behavior

The link in the email follows the APP_URL.

Environment

Your own self-hosted instance (monica v4)

Version of Monica

4.0.0

Installation method

Docker / k8s

Web server

Traefik / nginx

Database engine version

MariaDB

Additional info

I made an attempt to use APP_URL: https://monica.mydomain.com. I am now waiting for the next reminders to see whether that helps.

@chevdor chevdor added the bug label Feb 26, 2024
@chevdor
Copy link
Author

chevdor commented Feb 27, 2024

...and that did the trick.

TODO

  • update the doc to mention that APP_URL should be defined as APP_URL: https://monica.mydomain.com and not APP_URL: monica.mydomain.com
  • fix the code so that APP_URL: monica.mydomain.com does work, there is no reason to slide a localhost in there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant