Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip contactreminders for deleted contacts #7223

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

asbiin
Copy link
Member

@asbiin asbiin commented Apr 8, 2024

No description provided.

Copy link

sentry-io bot commented Apr 8, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: app/Domains/Contact/ManageReminders/Jobs/ProcessScheduledContactReminders.php

Function Unhandled Issue
App\Domains\Contact\ManageReminders\Jobs\ProcessScheduledContactReminders::handle TypeError: App\Helpers\NameHelper::formatContactName(): Argument #2 ($contact) must be of type App\Models\Co... /app/Help...
Event Count: 4.5k

Did you find this useful? React with a 👍 or 👎

Copy link

sentry-io bot commented Apr 8, 2024

Sentry Issue: STAGING-APP-8B

Copy link

sonarcloud bot commented Apr 8, 2024

@asbiin asbiin merged commit 7f932bd into main Apr 8, 2024
20 checks passed
@asbiin asbiin deleted the 20240408-reminders-contact-deleted branch April 8, 2024 21:53
Copy link

github-actions bot commented May 3, 2024

🎉 This PR is included in version 5.0.0-beta.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant