Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some topic unable to be flagged for removal #10182

Closed
WHATTHEDAN11 opened this issue Jan 7, 2024 · 11 comments
Closed

Some topic unable to be flagged for removal #10182

WHATTHEDAN11 opened this issue Jan 7, 2024 · 11 comments
Labels
enhancement making existing stuff better help wanted

Comments

@WHATTHEDAN11
Copy link

WHATTHEDAN11 commented Jan 7, 2024

I've noticed that some topics can't be flagged for removal by pressing 'x', for example: "Natsuki's letter", "Natuski's death". These topics can be bookmarked but cannot be removed for some reasons.

@Booplicate
Copy link
Member

It doesn't make sense to derandom them.

@Booplicate Booplicate closed this as not planned Won't fix, can't repro, duplicate, stale Feb 4, 2024
@WHATTHEDAN11
Copy link
Author

wdym?

@Booplicate
Copy link
Member

Why would you derandom them.

@WHATTHEDAN11
Copy link
Author

I just think its weird that these topics related to the other girls cant be derandomed. anyway, so basically those topics were intentionally made to not be able to derandom then?

@Booplicate
Copy link
Member

It's not about them being about other girls. The topics should be derandomed automatically, what do you expect to happen when you press X on a topic that's disabled?

@WHATTHEDAN11
Copy link
Author

I think u misunderstood what i meant, normally if u press X on a topic the top left will show "topic flagged for removal", but for topics such as "Natuski's death", when i pressed x, nothing happens

@Booplicate
Copy link
Member

Booplicate commented Feb 5, 2024

I understood you, so what do you expect to happen to the topics when you press X when they are already derandomed and cannot be rerandomed again?

You see the topics only once, normally, I don't understand what behaviour you're expecting, you want a new feature?

@Booplicate Booplicate reopened this Feb 5, 2024
@WHATTHEDAN11
Copy link
Author

Okay, so based on what you said, those topics in the "repeat conversation" section that does nothing when pressing X, are the topics that are already derandomed itself, even though they are within the "repeat conversation" section. Therefore nothing happens when trying to derandom them, correct?

@Booplicate
Copy link
Member

The topics being under the "repeat conversation" section has nothing to do with not being able to derandom them again. Any topic that you marked with "X" will still be present in the section anyway, so you can bring it up yourself.

When you press "X" during a conversation, it marks the topic as blocked from random selection. The topics you're having issue with can only be seen once (Monika does not repeat them). When you press "X" during one of the topics, you're asking to derandom a topic that's already derandomed and cannot be rerandomed due to its nature (it's a PM var topic).

Which is why I'm asking what you're expecting to happen.

@WHATTHEDAN11
Copy link
Author

ok. i just feel like it would be clearer if we would know that these topics cannot be derandomed since they naturally wont be mentioned by Monika again. Like before you telling me this i never knew PM var topics is a thing. Perhaps maybe when trying to derandom those topics, a message like: "Monika won't talk about these" on the top left would appear, suggesting that these topics are the PM var topic)

@Booplicate Booplicate added this to Unseen in Suggestion Pool via automation Feb 6, 2024
@Booplicate Booplicate added the enhancement making existing stuff better label Feb 6, 2024
@Booplicate
Copy link
Member

Makes sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement making existing stuff better help wanted
Projects
Suggestion Pool
  
Unseen
Development

No branches or pull requests

2 participants