Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check_http - make use of libcurl #1451

Closed
riskersen opened this issue Nov 30, 2016 · 5 comments
Closed

check_http - make use of libcurl #1451

riskersen opened this issue Nov 30, 2016 · 5 comments

Comments

@riskersen
Copy link
Collaborator

On IRC we discussed the possibility of extending check_http for more authentications mechanisms.

In the end, we agreed with libcurl, which would add some benefits to check_http

  • authentication protocols like NTLM, Kerberos, instead of only Basic to server and proxy
  • improved proxy support
  • selectable network interface for outgoing traffic
  • proven HTTP interface/features
  • follow redirects
  • HTTPS feature like specific SSL version and encryption

and so on, please see https://curl.haxx.se/docs/features.html for details.

From my perspective, this would lead to a complete rewrite, but the benefits aren't deniable.
Of course, we could also use libcurl for the check_ftp, but this would be another topic.

Unfortunately, i don't think i'm able to work on this request, due to the lack of deeper C knowledge.

What do you think about that?

@sni
Copy link
Contributor

sni commented Jan 10, 2017

We are in contact with the author of https://github.com/andreasbaumann/nagios-plugin-curl and will try to merge that one because its exactly what we are looking for already.

@riskersen
Copy link
Collaborator Author

These are very good news.

@ckujau
Copy link
Contributor

ckujau commented Sep 30, 2019

For the record, and since it came up on -devel recently: the nagios-plugin-curl repository URL has moved but apparently has been incorporated as a feature branch already. \o/

@andreasbaumann
Copy link
Contributor

andreasbaumann commented Sep 30, 2019

Adding additional authentication methods in check_curl is on the todo list:

https://github.com/monitoring-plugins/monitoring-plugins/blob/feature_check_curl/plugins/check_curl.c#L536

@RincewindsHat
Copy link
Member

well, check_curl is there, therefore I am closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants