Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MISSING_TO_STRING_OVERRIDE with invalid field #2

Closed
jsotuyod opened this issue Jun 8, 2015 · 0 comments
Closed

MISSING_TO_STRING_OVERRIDE with invalid field #2

jsotuyod opened this issue Jun 8, 2015 · 0 comments
Assignees
Labels

Comments

@jsotuyod
Copy link
Member

jsotuyod commented Jun 8, 2015

The folllowing class is reported as MISSING_TO_STRING_OVERRIDE

public class FSTSerializationStrategy implements SerializationStrategy {
    private final FSTConfiguration config;
        ...

This shouldn't happen as:

  1. FSTConfiguration doesn't override toString
  2. FSTConfiguration is a library class, and therefore, we can't add the missing toString to it.

The current detector should ignore fields that are not part of the application being analyzed, and do not override toString.

Possibly, the first condition can be tested using AnalysisContext.isApplicationClass(), though I'm not sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants