Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Missing nametag faction color #17

Open
4 tasks
monk-afk opened this issue May 24, 2024 · 0 comments
Open
4 tasks

[bug] Missing nametag faction color #17

monk-afk opened this issue May 24, 2024 · 0 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@monk-afk
Copy link
Owner

monk-afk commented May 24, 2024

Previous to the last update, Filterplus mod handled only chat tags, while factions would update the HUD nametag. It worked fine, but filterplus was requesting the player's Rank, Exp, and Faction, with every message that was sent in chat. This is not efficient, and could be improved.

It's may take some time, but i think the way forward with this is:

  • in FilterPlus, have a table of registered callback functions to request tags during player_join events from the mods.
  • These tags are then saved in the session table which already exists
  • F+ must also be able to update tags when the information changes, for example a faction name change, or level up.
  • i think that's it?

If figuring this out takes more time than I'm comfortable leaving this issue open, i'll set the nametags to how they were before the update, but this may cause the same high cpu time from F+ we had before

@monk-afk monk-afk added the bug Something isn't working label May 24, 2024
@monk-afk monk-afk self-assigned this May 24, 2024
@monk-afk monk-afk added the enhancement New feature or request label May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant