Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual Host Aliases (Trac #2) #2

Closed
edsiper opened this issue Jan 28, 2014 · 7 comments
Closed

Virtual Host Aliases (Trac #2) #2

edsiper opened this issue Jan 28, 2014 · 7 comments
Milestone

Comments

@edsiper
Copy link
Member

edsiper commented Jan 28, 2014

Currently Monkey Virtual Host configuration just accepts one host name, it
must accept aliases in order to avoid to have N virtual hosts defined, eg:

Current:

ServerName www.somesite.com

Expected:

ServerName somesite.com www.somesite.com calendar.somesite.com

Migrated from http://bugs.monkey-project.com/ticket/2

{
    "status": "closed", 
    "changetime": "2011-03-15T12:35:00", 
    "description": "Currently Monkey Virtual Host configuration just accepts one host name, it\nmust accept aliases in order to avoid to have N virtual hosts defined, eg:\n\nCurrent:\n\nServerName www.somesite.com\n\nExpected:\n\nServerName somesite.com www.somesite.com calendar.somesite.com\n", 
    "reporter": "edsiper", 
    "cc": "", 
    "resolution": "fixed", 
    "_ts": "1300192500509654", 
    "component": "Virtual Host", 
    "summary": "Virtual Host Aliases", 
    "priority": "major", 
    "keywords": "", 
    "version": "", 
    "time": "2010-05-15T12:47:37", 
    "milestone": "0.12.0", 
    "owner": "edsiper", 
    "type": "enhancement"
}
@edsiper
Copy link
Member Author

edsiper commented Jan 28, 2014

Trac update at 20100722T18:08:39: edsiper changed milestone from "0.11.0" to "0.12.0"

@edsiper
Copy link
Member Author

edsiper commented Jan 28, 2014

Trac update at 20100726T21:00:09:

  • charlie_brown changed attachment from "" to "Add-virtual-host-aliases-support.patch"
  • charlie_brown commented:

Add support for aliases

@edsiper
Copy link
Member Author

edsiper commented Jan 28, 2014

Trac update at 20100726T21:02:40: charlie_brown commented:

My proposal is to add an "Aliases" optional keyword. For example:

ServerName www.somesite.com
Aliases calendar.somesite.com othersite whatever

(patch attached)

@edsiper
Copy link
Member Author

edsiper commented Jan 28, 2014

Trac update at 20100726T21:24:25:

  • edsiper commented:

Thanks for the patch and proposal.

After review and re-think how we should handle this feature, the best one is to handle everything in the single variable ServerName, on this way we avoid to add an extra configuration key and at code level the parsing is more simple.

This implemented feature must avoid to copy strings when a request is parsed.

Also this feature must take care of the host information when is sent to different parts of the core, not just to match the right hostname.

  • edsiper changed status from "new" to "accepted"

@edsiper
Copy link
Member Author

edsiper commented Jan 28, 2014

Trac update at 20101108T19:31:00:

  • edsiper commented:

Fixed in :

http://git.monkey-project.com/?p=monkey;a=commitdiff;h=7163f64ed4b757d5bdc43e87c4815ea90e5f0d0c

Now the directive Servername, allow multiple aliases in the same line.

  • edsiper changed resolution from "" to "fixed"
  • edsiper changed status from "accepted" to "closed"

@edsiper
Copy link
Member Author

edsiper commented Jan 28, 2014

Trac update at 20110315T12:26:55:

  • amog2011 changed _comment0 from "Also this feature must take care of the host information when is sent to different parts of the core, not just to match the right hostname. air jordan" to "1300192037213282"
  • amog2011 commented:

Also this feature must take care of the host information when is sent to different parts of the core, not just to match the right hostname.

#!html
<a href="http://www.nicetick.com"><font color="http://bugs.monkey-project.com/ticket/0">air jordan</font></a>

@edsiper
Copy link
Member Author

edsiper commented Jan 28, 2014

Trac update at 20110315T12:35:00: edsiper commented:

Are you reporting a bug or an unexpected behavior ?, please provide more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant