fix: use appropriate fallback fonts (SethFalco) #4620
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a user who recently started using the web with downloadable fonts disabled, I noticed the experience of Monkeytype is very inconsistent with the normal experience.
This just adds an appropriate fallback font to any font declarations, so the UI is much closer to the experience of someone with downloadable fonts enabled.
The only odd one is
--font: "Roboto Mono", "Vazirmatn", monospace;
, where you have a monospace font, followed by a sans-serif font. For this, I appendedmonospace
to the end.References
Before
After