Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use appropriate fallback fonts (SethFalco) #4620

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

SethFalco
Copy link
Contributor

@SethFalco SethFalco commented Sep 11, 2023

Description

As a user who recently started using the web with downloadable fonts disabled, I noticed the experience of Monkeytype is very inconsistent with the normal experience.

This just adds an appropriate fallback font to any font declarations, so the UI is much closer to the experience of someone with downloadable fonts enabled.

The only odd one is --font: "Roboto Mono", "Vazirmatn", monospace;, where you have a monospace font, followed by a sans-serif font. For this, I appended monospace to the end.

References

You should always include at least one generic family name in a font-family list, since there's no guarantee that any given font is available.

https://developer.mozilla.org/en-US/docs/Web/CSS/font-family

Before

image

After

image

@monkeytypegeorge monkeytypegeorge added backend Server stuff frontend User interface or web stuff labels Sep 11, 2023
@Miodec
Copy link
Member

Miodec commented Sep 11, 2023

Thanks

@Miodec Miodec changed the title fix: use appropriate fallback fonts fix: use appropriate fallback fonts (SethFalco) Sep 11, 2023
@Miodec Miodec merged commit ecbc20f into monkeytypegame:master Sep 11, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Server stuff frontend User interface or web stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants