Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impr: increase favicon quality by using svg (fehmer) #4652

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

fehmer
Copy link
Member

@fehmer fehmer commented Sep 21, 2023

Description

Improve quality of the favicon by using svg. This scales with the requested size by the browser and is not fixed to 64x64 pixels as before.

Note: Current version seems not to be working in Safari, neither is the updated one.

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Sep 21, 2023
@fehmer fehmer marked this pull request as ready for review September 22, 2023 07:13
@fehmer
Copy link
Member Author

fehmer commented Sep 22, 2023

Tested browsers:

  • Windows
    -Chrome✅
    -Firefox✅
    -Edge✅
    -Opera GX ✅
  • Linux (Ubuntu)
    -Chrome✅
    -Firefox✅
    -Gnome Web (webkit based) ❌ (not showing, same with the old implementation)
  • MacOs
    -Chrome✅
    -Safari ❌ (not showing, same with the old implementation)

@Miodec Miodec changed the title impr: improve favicon quality by using svg impr: increase favicon quality by using svg (fehmer) Sep 25, 2023
@Miodec Miodec merged commit 5439d39 into monkeytypegame:master Sep 25, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend User interface or web stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants