Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impr(quotes): add 6 quotes (aikooo7) #4675

Merged
merged 7 commits into from
Oct 2, 2023

Conversation

aikooo7
Copy link
Contributor

@aikooo7 aikooo7 commented Sep 27, 2023

Description

I have added six English quotes to the project.

My pull request includes six quotes that I found during a search, and they are in English.

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Sep 27, 2023
@aikooo7 aikooo7 changed the title Impr: Added 6 more quotes. impr: Added 6 more quotes. Sep 27, 2023
@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/6331395328

Copy link
Member

@Miodec Miodec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things to update

@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/6354966470

@aikooo7
Copy link
Contributor Author

aikooo7 commented Sep 29, 2023

Just a note, my bad for all the quote size commits, sadly I always get it wrong, that ci for checking json is a really good feature.

@aikooo7 aikooo7 requested a review from Miodec October 1, 2023 20:31
@Miodec Miodec changed the title impr: Added 6 more quotes. impr(quotes): add 6 quotes (aikooo7) Oct 2, 2023
@Miodec Miodec merged commit c19db19 into monkeytypegame:master Oct 2, 2023
8 checks passed
@aikooo7 aikooo7 deleted the english_quotes branch October 2, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assets Languages, themes, layouts, etc. frontend User interface or web stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants