Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(language): add English Shakespearean (risograph) #4680

Merged
merged 8 commits into from
Oct 6, 2023
Merged

feat(language): add English Shakespearean (risograph) #4680

merged 8 commits into from
Oct 6, 2023

Conversation

risograph
Copy link
Contributor

Description

++ Added Shakespearean English language
List of ≈ 200 shakespearean words

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Sep 30, 2023
@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/6358864468

@Warrobot10
Copy link
Contributor

This pr would better fit as a feat:

@Warrobot10
Copy link
Contributor

Looks like the checks failed because there is a duplicate of a word you included.

@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/6360354884

@risograph risograph changed the title impr: Shakespearean English feat: Shakespearean English Sep 30, 2023
Miodec
Miodec requested changes Oct 2, 2023
View reviewed changes
Copy link
Member

@Miodec Miodec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename the file and language name to english_shakespearean and put it in the english group.

@Miodec Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label Oct 2, 2023
risograph and others added 2 commits October 3, 2023 11:45
@risograph
Add requested changes
f4feff8 
- Renamed lang
      - `shakespearean_english` >> `english_shakespearean`

- Added lang to `english` group
- Moved land under `english` group in list
@risograph
Merge branch 'master' into master
f08699e
@risograph risograph requested a review from Miodec October 3, 2023 18:46
@risograph
Copy link
Contributor Author

Should I add Shakespeare quotes along with this? It would tie it up nicely.

@Miodec
Copy link
Member

Miodec commented Oct 6, 2023

Should I add Shakespeare quotes along with this? It would tie it up nicely.

Sure

@Miodec
Copy link
Member

Miodec commented Oct 6, 2023 •
edited

Actually, this wont work with quote mode because it always switches the language to the group name.. Lets hold off on the quotes for now.

@Miodec Miodec changed the title feat: Shakespearean English feat(language): add English Shakespearean (risograph) Oct 6, 2023
@Miodec Miodec merged commit e9ebca6 into monkeytypegame:master Oct 6, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Miodec Miodec Awaiting requested review from Miodec

Assignees
No one assigned
Labels
assets Languages, themes, layouts, etc. frontend User interface or web stuff waiting for update Pull requests or issues that require changes/comments before continuing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@risograph @monkeytypegeorge @Warrobot10 @Miodec