Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impr(quotes): add guilty gear quote (remalucard) #4682

Merged
merged 6 commits into from
Oct 2, 2023

Conversation

remalucard
Copy link
Contributor

Description

added quote from guilty gear? idk if the text length is correct, if it's too short i'll just make it the song quote instead of game quote

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Oct 1, 2023
@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/6373878778

Copy link
Contributor

@Warrobot10 Warrobot10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comma at line 38692, just after the curly bracket. That should make sure the checks pass. Also, make sure correct grammar is used in the quote. To change things, just commit to your clone of monkeytype that you started the pull request against. One last thing, make sure you change the title to chore: (title here). This ensures that the contribution can automatically be added to the release notes.

@remalucard remalucard changed the title quote impr: quote ig Oct 2, 2023
@remalucard remalucard changed the title impr: quote ig chore: quote ig Oct 2, 2023
@remalucard remalucard closed this Oct 2, 2023
@remalucard
Copy link
Contributor Author

remalucard commented Oct 2, 2023

now it should be fine? idk i'm bad at this somehow

@remalucard remalucard reopened this Oct 2, 2023
@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/6380270786

@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/6380374416

@remalucard remalucard reopened this Oct 2, 2023
@remalucard
Copy link
Contributor Author

that was a pain but hey now i know how to do this properly

@Miodec Miodec changed the title chore: quote ig impr(quotes): add guilty gear quote (remalucard) Oct 2, 2023
@Miodec
Copy link
Member

Miodec commented Oct 2, 2023

that was a pain but hey now i know how to do this properly

New skill unlocked ;)

@Miodec Miodec merged commit 6096b0c into monkeytypegame:master Oct 2, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assets Languages, themes, layouts, etc. frontend User interface or web stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants