-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
impr(quotes): add guilty gear quote (remalucard) #4682
Conversation
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/6373878778 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a comma at line 38692, just after the curly bracket. That should make sure the checks pass. Also, make sure correct grammar is used in the quote. To change things, just commit to your clone of monkeytype that you started the pull request against. One last thing, make sure you change the title to chore: (title here). This ensures that the contribution can automatically be added to the release notes.
now it should be fine? idk i'm bad at this somehow |
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/6380270786 |
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/6380374416 |
that was a pain but hey now i know how to do this properly |
New skill unlocked ;) |
Description
added quote from guilty gear? idk if the text length is correct, if it's too short i'll just make it the song quote instead of game quote