impr: notification cards redesign #4700
Conversation
|
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/6396445274 |
|
From the screenshots provided, I’m assuming the notifications are transparent. This kind of looks clunky, because you can see the ui elements underneath. |
I have a different take on this part 😕. I think the transparency actually lightens things up a bit and gives it a more airy feel. But, I'm cool with the idea of bumping up the opacity a smidge. What do you think? |
|
Yeah, I think having the opacity raised would make it seem a bit nicer. Thanks! |
Changed!! |
|
Im kinda not feeling this one. Don't like that only the error icon is colored. I think i don't like the opacity at all (maybe it would be better if it blurred stuff behind it but not sure if thats possible). And the title text color being the same as message color. Also the level 0 (blue) border color is not as visible as the others, and its border is too thin i think. |
Miodec
added
the
waiting for update
|
This PR is stale. Please trigger a re-run of the PR check action. |
github-actions
bot
added
Stale
|
Sorry for the wait, but I've managed to make the requested changes. Take a look at this screenshot of the new design.
|
|
What do you think about this |
|
That's a great way to solve it! |
Description
After chatting about it in #4688, I've decided to take on the challenge of giving the Notification Center notification cards a makeover. The main reason for this is that some of our current themes don't quite nail the color contrast, and I think adopting a consistent color scheme could be the key to sorting out these issues.
Final Results:
Closes: It closes the #4688 discussion.