Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impr: floor accuracy intead of rounding when not showing decimal places (fehmer) #5120

Merged
merged 3 commits into from
Feb 26, 2024

Conversation

fehmer
Copy link
Member

@fehmer fehmer commented Feb 24, 2024

Description

use Math.floor when displaying accuracy values without decimal places.

Fixes #5114

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Feb 24, 2024
@fehmer fehmer changed the title impr: floor accuracy intead of rounding when not showing decimal places impr: floor accuracy intead of rounding when not showing decimal places (fehmer) Feb 25, 2024
Copy link
Member

@Miodec Miodec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on using Format.accuracy instead of Format.percentage and having to define rounding everywhere? Risks someone forgetting to floor.

@fehmer fehmer force-pushed the feature/floor-accuracy-instead-of-rounding branch from 17e12be to d531457 Compare February 26, 2024 12:52
@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/8049169408

@fehmer fehmer force-pushed the feature/floor-accuracy-instead-of-rounding branch from d531457 to 310e7ed Compare February 26, 2024 14:01
Copy link
Member

@Miodec Miodec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Miodec Miodec merged commit 69dff92 into master Feb 26, 2024
7 checks passed
@Miodec Miodec deleted the feature/floor-accuracy-instead-of-rounding branch February 26, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend User interface or web stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Floor accuracy instead of rounding when not showing decimal places
3 participants