Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session time isn't updated after failed tests #5183

Closed
2 tasks done
gretaSamsa opened this issue Mar 5, 2024 · 3 comments
Closed
2 tasks done

Session time isn't updated after failed tests #5183

gretaSamsa opened this issue Mar 5, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@gretaSamsa
Copy link

Did you clear cache before opening an issue?

  • I have cleared my cache

Is there an existing issue for this?

  • I have searched the existing issues

Does the issue happen when logged in?

Yes

Does the issue happen when logged out?

Yes

Does the issue happen in incognito mode when logged in?

Yes

Does the issue happen in incognito mode when logged out?

Yes

Account name

greta_samsa

Account config

No response

Current Behavior

The session time does not increase after a failed test. The time spent during failed tests is tracked, but is only updated after a successful test.

Expected Behavior

Session time should accurately reflect the amount of time spent at the end of each test, even if you failed the test.

Steps To Reproduce

  1. Change settings to allow test failure (for example, set difficulty to master).
  2. Fail several tests. Note that the session time field never appears.
  3. Complete a test successfully. Note that the session time field now shows the total time spent, including during the failed tests.

Environment

  • OS: Windows 11
  • Browser: Firefox
  • Browser Version: 123.0

Anything else?

No response

@gretaSamsa gretaSamsa added the bug Something isn't working label Mar 5, 2024
@gretaSamsa
Copy link
Author

This also causes the "time spent typing" tracker to be inaccurate, for example if you spend several hours attempting long tests on master only the time spent up to your last completed test will be tracked.

@sanidhyas3s
Copy link
Contributor

I think this is more of a decision than a bug. @Miodec What's your opinion on this?

@Miodec
Copy link
Member

Miodec commented Mar 5, 2024

This is by design. The time spent typing on failed tests is attached to the next successful test submission - this is done to avoid sending a request to the server everytime a test is failed, and provide some data validation.

@Miodec Miodec closed this as not planned Won't fix, can't repro, duplicate, stale Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants