Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent automatic double newline input when quick restart set to enter (sanidhyas3s) #5184

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

sanidhyas3s
Copy link
Contributor

Description

Prevent manual resolution of \n when quick restart is set to enter and test has newline.

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language or a theme?
    • If is a language, did you edit _list.json, _groups.json and add languages.json?
    • If is a theme, did you add the theme.css?
      • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username inside parentheses at the end of the PR title

Closes #5175

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Mar 5, 2024
@Miodec
Copy link
Member

Miodec commented Mar 5, 2024

Hmm.. looks like there is some duplicated logic somewhere if this fixes both cases (single and double enter). Thanks

@Miodec Miodec merged commit 2fb77a1 into monkeytypegame:master Mar 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend User interface or web stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Having quick restart set to enter causes automatic double newline input
3 participants