Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impr(quotes): add English quotes (TheExploration) #5190

Merged
merged 4 commits into from
Mar 11, 2024
Merged

impr(quotes): add English quotes (TheExploration) #5190

merged 4 commits into from
Mar 11, 2024

Conversation

TheExploration
Copy link
Contributor

@TheExploration TheExploration commented Mar 6, 2024 •
edited

Description

Add 2 English quotes

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language or a theme?
    • If is a language, did you edit _list.json, _groups.json and add languages.json?
    • If is a theme, did you add the theme.css?
      • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username inside parentheses at the end of the PR title

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Mar 6, 2024
Miodec
Miodec requested changes Mar 11, 2024
View reviewed changes
frontend/static/quotes/english.json Outdated Show resolved Hide resolved
@Miodec Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label Mar 11, 2024
TheExploration
TheExploration commented Mar 11, 2024
View reviewed changes
Copy link
Contributor Author

@TheExploration TheExploration left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed quote

@Miodec Miodec merged commit ab5c130 into monkeytypegame:master Mar 11, 2024
7 checks passed
@Miodec
Copy link
Member

Miodec commented Mar 11, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Miodec Miodec Awaiting requested review from Miodec

Assignees
No one assigned
Labels
assets Languages, themes, layouts, etc. frontend User interface or web stuff waiting for update Pull requests or issues that require changes/comments before continuing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TheExploration @Miodec @monkeytypegeorge