Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impr(profile/account page): show leaderboard rank percentage (fehmer) #5212

Merged
merged 7 commits into from Mar 25, 2024

Conversation

fehmer
Copy link
Member

@fehmer fehmer commented Mar 11, 2024

Description

Add rank percentage of the all time leaderboards to the account and profile page:

image

@monkeytypegeorge monkeytypegeorge added the backend Server stuff label Mar 11, 2024
@fehmer fehmer marked this pull request as draft March 11, 2024 10:41
@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Mar 11, 2024
Base automatically changed from feature/use-alltimelb-for-account-page to master March 11, 2024 19:29
@Miodec
Copy link
Member

Miodec commented Mar 11, 2024

I would place it under the "15/60 seconds"

@Miodec Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label Mar 11, 2024
@fehmer fehmer force-pushed the feature/add-rank-percentage-to-profile branch from 7726335 to bdd63a5 Compare March 11, 2024 21:22
@fehmer fehmer marked this pull request as ready for review March 11, 2024 21:34
@fehmer fehmer removed the waiting for update Pull requests or issues that require changes/comments before continuing label Mar 12, 2024
ruru-m07

This comment was marked as duplicate.

Copy link

@ruru-m07 ruru-m07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all changes looks ok.

@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/8343636601

@Miodec Miodec changed the title impr: show leaderboard rank percentage on account/profile page (fehmer) impr(profile): show leaderboard rank percentage(fehmer) Mar 25, 2024
@Miodec Miodec changed the title impr(profile): show leaderboard rank percentage(fehmer) impr(profile): show leaderboard rank percentage (fehmer) Mar 25, 2024
@Miodec Miodec changed the title impr(profile): show leaderboard rank percentage (fehmer) impr(profile/account page): show leaderboard rank percentage (fehmer) Mar 25, 2024
@Miodec Miodec merged commit a306ab4 into master Mar 25, 2024
10 checks passed
@Miodec
Copy link
Member

Miodec commented Mar 25, 2024

Thanks

@Miodec Miodec deleted the feature/add-rank-percentage-to-profile branch March 25, 2024 11:36
Copy link

@ruru-m07 ruru-m07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE WORK 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Server stuff frontend User interface or web stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants