impr(profile): add level percentage when hovering over progress bar (vjgtigers) #5276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vjgtigers
changed the title
|
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/8532204264 |
|
From the screenshots it looks like the vertical alignment is off. Please try to fix it. |
Miodec
added
the
waiting for update
|
fixed xp bar alignment Updated account and profile view page:
Updated profile view page:
|
Miodec
changed the title
|
I broke the PR somehow.... Can you hard reset to the "update styling a tiny bit" commit, then force push? |
|
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/8548861329 |
|
Should be working again |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added code so when the users mouse hovers over the progress bar the percent complete of that level is displayed
Also:
added "data-balloon-pos="up"" so that the total user xp on profile view will new appear
Closes #
pull [#5269]
messed up the branch when changing and couldn't fix it
on account and profile view page:
on profile view page: