Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set correct delimiter and digits for bangla (shahnewaz-labib) #5355

Merged
merged 5 commits into from
May 6, 2024
Merged

fix: set correct delimiter and digits for bangla (shahnewaz-labib) #5355

merged 5 commits into from
May 6, 2024

Conversation

shahnewaz-labib
Copy link
Contributor

@shahnewaz-labib shahnewaz-labib commented May 2, 2024 •
edited

Description

  • There's no "." (period) in bangla, instead there's "।". Simply doing a regex match and replacing the period with the appropriate character. It was already implemented for Nepali language.

  • For latin numerals, converting them to proper bangla numerals

Current deployment

  • Notice the english numerals and periods
    image

After changes

  • Notice the "।"s (no periods) and bangla numerals
    image

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language or a theme?
    • If is a language, did you edit _list.json, _groups.json and add languages.json?
    • If is a theme, did you add the theme.css?
      • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username inside parentheses at the end of the PR title

Closes #4696

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label May 2, 2024
@shahnewaz-labib
Copy link
Contributor Author

@ruru-m07 Is there anything blocking the merge?

ruru-m07
ruru-m07 reviewed May 5, 2024
View reviewed changes
Copy link

@ruru-m07 ruru-m07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks every thing ok...

@Miodec
Copy link
Member

Miodec commented May 6, 2024

Please resolve conflicts.

@Miodec Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label May 6, 2024
@shahnewaz-labib
Copy link
Contributor Author

@Miodec resolved.

Miodec
Miodec approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@Miodec Miodec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Miodec Miodec merged commit 8705b1c into monkeytypegame:master May 6, 2024
7 checks passed
Miodec pushed a commit to StickminBruv/monkeytype that referenced this pull request May 8, 2024
@shahnewaz-labib @Miodec
fix(word generation): use correct fullstop and digits for bangla (sha…
6548ebb 
…hnewaz-labib) (monkeytypegame#5355)

* fix: add "।" instead of "." if bangla word

* fix: convert to bangla numerals
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Miodec Miodec Miodec approved these changes

@ruru-m07 ruru-m07 ruru-m07 approved these changes

Assignees
No one assigned
Labels
frontend User interface or web stuff waiting for update Pull requests or issues that require changes/comments before continuing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delimiter Problem in Bengali Language
4 participants
@shahnewaz-labib @Miodec @ruru-m07 @monkeytypegeorge