Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(quotes): replace /n with \n (extoplasm) #5356

Merged
merged 16 commits into from
May 6, 2024
Merged

fix(quotes): replace /n with \n (extoplasm) #5356

merged 16 commits into from
May 6, 2024

Conversation

extoplasm
Copy link
Contributor

Description

sorry, didn't notice until i checked on the website, i used /n instead of \n

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language or a theme?
    • If is a language, did you edit _list.json, _groups.json and add languages.json?
    • If is a theme, did you add the theme.css?
      • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username inside parentheses at the end of the PR title

Closes #

extoplasm and others added 14 commits April 25, 2024 11:00
@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels May 3, 2024
@Miodec Miodec changed the title fix(quotes): accidentally did /n when should have been \n in id 5 quote chinese_simplified.json extoplasm fix(quotes): replace /n with \n (extoplasm) May 6, 2024
@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/8969043657

@Miodec Miodec merged commit 9b41131 into monkeytypegame:master May 6, 2024
7 checks passed
Miodec added a commit to StickminBruv/monkeytype that referenced this pull request May 8, 2024
@extoplasm @Miodec
fix(quotes): replace /n with \n (extoplasm) (monkeytypegame#5356)
55dba32 
* added two quotes in chinese_simplified.json

* Update chinese_simplified.json

miscounted length of first quote

* updated quotes, added more

* Update chinese_simplified.json

miscounted quote lengths (again) (oops)

* accidentally did forward slash when doing newline

* fix length

---------

Co-authored-by: Jack <jack@monkeytype.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruru-m07 ruru-m07 ruru-m07 approved these changes

Assignees
No one assigned
Labels
assets Languages, themes, layouts, etc. frontend User interface or web stuff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@extoplasm @monkeytypegeorge @ruru-m07 @Miodec