Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set correct delimiter and digits for hindi (shahnewaz-labib) #5366

Merged
merged 2 commits into from
May 6, 2024

Conversation

shahnewaz-labib
Copy link
Contributor

Description

Description

  • Adding "।" to the word as period.
  • For latin numerals, converting them to proper hindi numerals

Current deployment

image

After changes

image

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language or a theme?
    • If is a language, did you edit _list.json, _groups.json and add languages.json?
    • If is a theme, did you add the theme.css?
      • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username inside parentheses at the end of the PR title

Closes #5365

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label May 6, 2024
Copy link
Member

@Miodec Miodec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Miodec Miodec merged commit e88601d into monkeytypegame:master May 6, 2024
7 checks passed
Miodec pushed a commit to StickminBruv/monkeytype that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend User interface or web stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong hindi punctuation (period) and numerals
3 participants