Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: maintain blocklist of banned usernames and email (fehmer) #5371

Merged
merged 2 commits into from
May 20, 2024
Merged

feat: maintain blocklist of banned usernames and email (fehmer) #5371

merged 2 commits into from
May 20, 2024

Conversation

fehmer
Copy link
Member

@fehmer fehmer commented May 7, 2024 •
edited

On deletion of a banned user keep a list of hashed username, email and optional discordId and prevent those user to signup and link discord.

@monkeytypegeorge monkeytypegeorge added backend Server stuff frontend User interface or web stuff labels May 7, 2024
@fehmer fehmer marked this pull request as ready for review May 7, 2024 22:18
@fehmer fehmer marked this pull request as draft May 8, 2024 14:24
Miodec
Miodec reviewed May 9, 2024
View reviewed changes
backend/src/dal/blocklist.ts Outdated Show resolved Hide resolved
@fehmer fehmer force-pushed the feature/add-email-and-username-blocklist branch from 5b1d030 to 8cd1a84 Compare May 16, 2024 08:45
@fehmer fehmer marked this pull request as ready for review May 16, 2024 08:55
@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/9109410429

1 similar comment
@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/9109410429

@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/9111047633

@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/9111405021

@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/9111452982

1 similar comment
@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/9111452982

@fehmer fehmer force-pushed the feature/add-email-and-username-blocklist branch from fe50bf1 to 8cd1a84 Compare May 16, 2024 11:36
@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/9111553548

@fehmer fehmer force-pushed the feature/add-email-and-username-blocklist branch from 8cd1a84 to b324bb8 Compare May 17, 2024 10:26
@monkeytypegeorge monkeytypegeorge removed the frontend User interface or web stuff label May 17, 2024
@fehmer fehmer force-pushed the feature/add-email-and-username-blocklist branch from b324bb8 to f834640 Compare May 17, 2024 10:30
Miodec
Miodec previously approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@Miodec Miodec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label May 20, 2024
@Miodec Miodec merged commit 4589bbf into master May 20, 2024
6 checks passed
@Miodec Miodec deleted the feature/add-email-and-username-blocklist branch May 20, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Miodec Miodec Miodec left review comments

Assignees
No one assigned
Labels
backend Server stuff frontend User interface or web stuff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fehmer @monkeytypegeorge @Miodec