Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .NET 7 Support for Blazor views #2254

Merged
merged 8 commits into from Sep 30, 2022
Merged

Add .NET 7 Support for Blazor views #2254

merged 8 commits into from Sep 30, 2022

Conversation

mattleibow
Copy link
Contributor

@mattleibow mattleibow commented Sep 15, 2022

Description of Change

Make sure to use the new build of the wasm binary for .NET 7 Blazor Apps.

TODO

  • Make use of SIMD flags

bricelam
bricelam previously approved these changes Sep 15, 2022
@danwalmsley
Copy link

@mattleibow just a heads up... that Blazor skiasharp views are broken under dotnet 7.

https://github.com/mono/SkiaSharp/blob/main/source/SkiaSharp.Views.Blazor/SkiaSharp.Views.Blazor/wwwroot/SKHtmlCanvas.ts#L114

This GL symbol is not in scope.

Dont quote me on this, but my conclusion from spending a day investigating is:

net 6, ES6 modules are not used: GL is a global variable.

net7 dotnet.js is using ES6 modules, and GL is now private and isnt exported.

something generates the js code for the GL stuff and stuffs it in (dotnet.js). I am unable to determine the thing that generates this source thus far.

for now ill continue to find a workaround, but maybe you know something ?

@danwalmsley
Copy link

@mattleibow added an issue to runtime repo:

dotnet/runtime#76077

@mattleibow mattleibow changed the title Build a version of wasm for net7 Add .NET 7 Support for Blazor views Sep 29, 2022
@mattleibow mattleibow merged commit ddfa128 into main Sep 30, 2022
@mattleibow mattleibow deleted the dev/net7-wasm branch September 30, 2022 04:13
@mattleibow mattleibow added this to the v2.88.3 milestone Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants