Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SkiaSharp XF Sample in .NETStandard 1.4 #352

Closed
JimSEOW opened this issue Aug 14, 2017 · 3 comments
Closed

SkiaSharp XF Sample in .NETStandard 1.4 #352

JimSEOW opened this issue Aug 14, 2017 · 3 comments
Projects

Comments

@JimSEOW
Copy link

JimSEOW commented Aug 14, 2017

I am testing bringing the XF Skiasharp sample to .NETStandard 1.4 for UWP
The only issue is instead of PCLStorage v1.0.2, I choose [PCLStorage.Standard compile with .NETStandard 1.4] (https://github.com/losttech/PCLStorage.Desktop/tree/netStandard)

Two samples fail

  • CreatePdfSample
  • CreateXpsSample
    because of dependency on FileSystem.cs which is missing in PCLStorage.Standard branch
@mattleibow
Copy link
Contributor

mattleibow commented Aug 22, 2017

@JimSEOW Thanks for looking into this. With .NET Standard 1.3+, there is no need for the PCLStorage as the File APIs (System.IO) are all available.

If we are going .NET Standard, rather switch to that API.

@JimSEOW
Copy link
Author

JimSEOW commented Aug 22, 2017

@mattleibow UWP6.0 is expected to be released end of this month. By then, we could bring Xamarin Foms to .NET standard 2.0 for iOS, Android and UWP and then we could re-visit this topics.

@mattleibow
Copy link
Contributor

I had a look, and managed to get the sample to .NET Standard: 37fae29

Thanks for the issue and the research. It is still a bit rough, (stable) Xamarin.Forms does not yet nicely support .NET Standard, so I had to add: <PackageTargetFallback>portable-net45+win8+wpa81+wp8</PackageTargetFallback> to the .csproj. Not too bad, but hopefully as soon as 2.4 goes stable, we can remove it.

Also, UWP is still a bit annoying, it doesn't support a pure .csproj format. I moved the package references into the project file, but I still have to keep that project.json around. All the other projects use the new packages format.

@mattleibow mattleibow added this to Complete / Invalid in Triage May 5, 2018
@ghost ghost locked as resolved and limited conversation to collaborators Aug 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Triage
  
Done
Development

No branches or pull requests

2 participants