Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win-x64 publish with Core3 Preview and VS2019 results in ""CheckEmbeddedRootDescriptor" task was not given a value for the required parameter "AssemblyPath"" #428

Closed
OliaG opened this issue Dec 19, 2018 · 10 comments

Comments

@OliaG
Copy link
Member

OliaG commented Dec 19, 2018

From @stefanov-stefan on December 5, 2018 16:11

I have been trying to publish a plain dotnet new winforms app by following the steps here, but I end up with error: error MSB4044: The "CheckEmbeddedRootDescriptor" task was not given a value for the required parameter "AssemblyPath".

See attached image for the whole process.

I am running VS2019 Preview and have the following SDKs installed: https://www.screencast.com/t/29MbjIeY04

Any advice on how I can overcome this?
linker_issue

Copied from original issue: dotnet/winforms#210

@OliaG
Copy link
Member Author

OliaG commented Dec 19, 2018

From @tomrus88 on December 8, 2018 18:31

I've had exactly same error when I used ILLink.Tasks package, publish works fine without it. So it must be some problem with ILLink.Tasks, not winforms?

@OliaG
Copy link
Member Author

OliaG commented Dec 19, 2018

From @jeffschwMSFT on December 11, 2018 16:24

cc @sbomer

@OliaG
Copy link
Member Author

OliaG commented Dec 19, 2018

From @l0hn on December 17, 2018 12:31

This error occurs if you add ILLink.Tasks to a fresh core 3.0 console app so I don't think this is specific to winforms.

@OliaG
Copy link
Member Author

OliaG commented Dec 19, 2018

@jeffschwMSFT @sbomer it looks like general ILLink.Tasks problem. Where do you track those bugs? Can we move this issue there as it is not WinForms specific

@OliaG
Copy link
Member Author

OliaG commented Dec 19, 2018

From @sbomer on December 18, 2018 1:6

@OliaG Feel free to move it to https://github.com/mono/linker. This is happening because the linker hasn't been updated to work with the 3.0 SDK, which is something we're working on.

@pveliz
Copy link

pveliz commented Jan 18, 2019

@OliaG I'm facing the same issue with a console app in .Net Core 3.0

C:\XXXXX\poc\SizeAppILLinker>dotnet publish -c release -r win-x64 -o out
Microsoft (R) Build Engine version 16.0.225-preview+g5ebeba52a1 for .NET Core
Copyright (C) Microsoft Corporation. All rights reserved.

Restoring packages for C:\XXXXX\poc\SizeAppILLinker\SizeAppILLinker.csproj...
Restore completed in 173.99 ms for C:\XXXXX\poc\SizeAppILLinker\SizeAppILLinker.csproj.
C:\Program Files\dotnet\sdk\3.0.100-preview-009812\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.RuntimeIdentifierInference.targets(142,5): message NETSDK1057: You are using a preview version of .NET Core. See: https://aka.ms/dotnet-core-preview [C:\XXXXX\poc\SizeAppILLinker\SizeAppILLinker.csproj]
SizeAppILLinker -> C:\XXXXX\poc\SizeAppILLinker\bin\Release\netcoreapp2.2\win-x64\SizeAppILLinker.dll
C:\Users\pablo.veliz.nuget\packages\illink.tasks\0.1.5-preview-1841731\build\ILLink.Tasks.targets(451,5): error MSB4044: The "CheckEmbeddedRootDescriptor" task was not given a value for the required parameter "AssemblyPath". [C:\XXXXX\poc\SizeAppILLinker\SizeAppILLinker.csproj]

Thanks

@jeffschwMSFT
Copy link
Member

This issue is related to the SDK drifting slightly from our current state. Our goal in an upcoming preview for .NET Core 3.0 is to integrate into the SDK to help eliminate these sorts of issues.

cc @sbomer @cshung

@wieslawsoltes
Copy link

Have same issue when using .NET Core 3.0 (3.0.100-preview-010184)

2019-02-01T18:15:04.4265533Z ##[error]C:\Users\VssAdministrator\.nuget\packages\illink.tasks\0.1.5-preview-1841731\build\ILLink.Tasks.targets(451,5): error MSB4044: The "CheckEmbeddedRootDescriptor" task was not given a value for the required parameter "AssemblyPath". [D:\a\1\s\src\ThemeEditor\ThemeEditor.csproj]
2019-02-01T18:15:04.4266070Z ##[error]Process 'dotnet.exe' exited with code 1.

@marek-safar
Copy link
Contributor

@sbomer was this issue already addressed?

@sbomer
Copy link
Member

sbomer commented Oct 3, 2019

Yes, this should be fixed in the 3.0 SDK with PublishTrimmed.

@sbomer sbomer closed this as completed Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants