Skip to content

Commit

Permalink
Remove Windows support completely for now
Browse files Browse the repository at this point in the history
Since the managed libraries are built on Windows when packaging, the
released nuget would get a Mono.Unix.dll which would attempt to look
up `libc` symbols in `msvcrt`, which would break.  Since we currently
don't support Windows at all, remove support for `msvcrt`

Bump version to 7.1.0
  • Loading branch information
grendello committed Sep 7, 2021
1 parent 74d504f commit d8994ca
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 9 deletions.
4 changes: 0 additions & 4 deletions Mono.Unix.Common.props
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,4 @@
<StrongNameKeyId>Open</StrongNameKeyId>
<LangVersion>latest</LangVersion>
</PropertyGroup>

<PropertyGroup Condition=" '$([MSBuild]::IsOSPlatform(Windows))' == 'false' ">
<DefineConstants>$(DefineConstants);FORCE_USE_LIBC_NOT_MSVC</DefineConstants>
</PropertyGroup>
</Project>
2 changes: 1 addition & 1 deletion eng/Versions.props
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<PropertyGroup>
<VersionPrefix>7.0.1</VersionPrefix>
<VersionPrefix>7.1.0</VersionPrefix>
<!-- <PreReleaseVersionLabel>final</PreReleaseVersionLabel>
<PreReleaseVersionIteration>1</PreReleaseVersionIteration> -->
</PropertyGroup>
Expand Down
4 changes: 0 additions & 4 deletions src/Mono.Unix/Mono.Unix.Native/Stdlib.cs
Original file line number Diff line number Diff line change
Expand Up @@ -384,11 +384,7 @@ static XPrintfFunctions ()
//
public class Stdlib
{
#if FORCE_USE_LIBC_NOT_MSVC
internal const string LIBC = "c";
#else
internal const string LIBC = "msvcrt";
#endif
internal const string MPH = "Mono.Unix";

// It is possible for Mono.Posix and Mono.Unix to get out of sync,
Expand Down

0 comments on commit d8994ca

Please sign in to comment.