Use functions instead of macros for is_in/is_out. #17350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipnavara
reviewed
Oct 16, 2019
|
And you’ll absorb this there? |
|
Let's proceed with this one I guess. I'll submit it once this gets merged. |
lambdageek
approved these changes
Oct 17, 2019
|
@filipnavara the more I look at these two predicates, the more I wish that there was a comment that explained that they're meant to treat byref params as both in and out. It looked fine yesterday, but today I keep having to look twice. |
|
@monojenkins squash |
|
@monojenkins build failed |
ManickaP
pushed a commit
to ManickaP/runtime
that referenced
this pull request
Jan 20, 2020
Use functions instead of macros for is_in/is_out. Commit migrated from mono/mono@edafa02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.