Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate if SKStream can derive System.IO.Stream #8

Closed
migueldeicaza opened this issue Feb 22, 2016 · 3 comments
Closed

Investigate if SKStream can derive System.IO.Stream #8

migueldeicaza opened this issue Feb 22, 2016 · 3 comments

Comments

@migueldeicaza
Copy link
Contributor

And implement its methods in terms of Stream, instead of introducing new names

@migueldeicaza
Copy link
Contributor Author

I see we were thinking about this from two different viewpoints.

Your viewpoint wraps a C# stream into something that can be surfaced to the Skia world, this is very useful.

My request is to make SKStream subclass Stream so that existing APIs in C# that consume streams can be used with SKStreams. This means that we could use SKStreams everywhere where we expect an instance of Stream. But perhaps there is no much use for it, and perhaps we could just live with a "proxy", like SKStream.AsStream() that returns a Stream that can be used to access the underlying stream if needed.

Flagging this as low-priority, until we have better use case.

@mattleibow
Copy link
Contributor

I am closing this as this will involve changing a few base types. Also, I don't think it will be possible as we need to preserve the skia type hierarchy. All is not lost, as there are extension methods and wrappers that can be used with the native streams, without a performance hit.

@mattleibow mattleibow added this to To Be Classified in Previous Releases Jul 26, 2018
mattleibow pushed a commit that referenced this issue Jun 11, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Aug 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Previous Releases
To Be Classified
Development

No branches or pull requests

2 participants