Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

latest_result.txt is different on different macs #83

Closed
xuaninbox opened this issue Jan 25, 2018 · 1 comment
Closed

latest_result.txt is different on different macs #83

xuaninbox opened this issue Jan 25, 2018 · 1 comment
Assignees
@mono0926 @xuaninbox
Labels
enhancement
Milestone
Version 1.9 Release

Comments

@xuaninbox
Copy link

LicensePlist/Sources/LicensePlistCore/Entity/PlistInfo.swift

Line 48 in ccf5d5b

let contents = (cocoaPodsLicenses.map { String(describing: $0) } +

.map will generate the lists in different order, maybe sort after map?
@mono0926 mono0926 self-assigned this Jan 25, 2018
@mono0926 mono0926 added this to the Version 1.9 Release milestone Jan 25, 2018
@mono0926 mono0926 mentioned this issue Jan 28, 2018
Merged
@mono0926
Copy link
Owner

mono0926 commented Jan 28, 2018 •
edited

@xuaninbox

.map will keep orders, but cocoaPodsLicenses order may be different on different mac.
So, I added sorted() before .map, and released 1.8.3.
Could you confirm that the results are same among different macs?

@mono0926 mono0926 closed this as completed Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mono0926 mono0926

@xuaninbox xuaninbox

Labels
enhancement
Projects
None yet
Milestone
Version 1.9 Release
Development

No branches or pull requests
2 participants
@mono0926 @xuaninbox