Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Gradle 8 support #73

Open
casper-rinnai opened this issue Jun 1, 2023 · 4 comments
Open

[Bug] Gradle 8 support #73

casper-rinnai opened this issue Jun 1, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@casper-rinnai
Copy link

flutter/flutter#125181

Flutter app android module can't be upgraded to gradle 8, until all dependencies which use native code are also upgraded or at least have namespace in app/build.gradle.

android {
namespace = "com.example.myapp"
...
}

@casper-rinnai casper-rinnai added the bug Something isn't working label Jun 1, 2023
@ArocaAlejandro
Copy link

Downgrade your build to gradle 7.

Only need to add the namespace for the module in the package for working with the newest requisites from gradle 8.x. Can do it manually until they fix it entering in the package and adding the namespace="de.mintware.barcode_scan"

@ArocaAlejandro
Copy link

ArocaAlejandro commented Dec 1, 2023

I've do a temporaly fix

In the android/build.gradle change the android to

android {
    namespace "de.mintware.barcode_scan"
    compileSdkVersion 31

    compileOptions {
    sourceCompatibility JavaVersion.VERSION_17
    targetCompatibility JavaVersion.VERSION_17
}
kotlinOptions {
    jvmTarget = '17'
}

    sourceSets {
        main.java.srcDirs += 'src/main/kotlin'
        main.proto.srcDirs += '../protos'
    }
    defaultConfig {
        minSdkVersion 18
        testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
        consumerProguardFiles 'proguard-rules.pro'
    }
    lintOptions {
        disable 'InvalidPackage'
    }
}

I will try later out of my work and run the tests. If I can build it with those parameters and got it fine, i do a pull request

@Letalus
Copy link

Letalus commented Dec 6, 2023

@ArocaAlejandro do you have any updates on here?

@ArocaAlejandro
Copy link

Sorry, i don't see the mail with the response, i've answered on this

#78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants