-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sigmoid or Softmax missing in evaluation #5
Comments
It's totally true that there is a mistake. I'm fixing the issue on this branch (d47dfed) and re-running the models. As training is over, I'll reupload the model & result! Thank you for informing the issue |
Does this affect the already fine-tuned models (like the ones on the model hub of Hugging Face) or is it just a matter of metrics computation while fine-tuning? |
This one doesn't affect the fine-tuned models, but there might be a possibility that the model from huggingface model hub isn't the best model cuz I've chose the model based on the wrong metrics |
Right, makes perfectly sense. Looking forward to your new results! Thanks! |
Fixed on b75f9d3 :) Also huggingface s3 models are updated! |
Shouldn't sigmoid(multilabel classification) or softmax(multiclass classification) be applied here to get the predictions? Otherwise, later the thresholds are being applied on the logits directly.
GoEmotions-pytorch/run_goemotions.py
Line 183 in 47f5afb
The text was updated successfully, but these errors were encountered: