Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sigmoid or Softmax missing in evaluation #5

Closed
shakib-root opened this issue Jan 14, 2021 · 5 comments
Closed

Sigmoid or Softmax missing in evaluation #5

shakib-root opened this issue Jan 14, 2021 · 5 comments
Labels
bug Something isn't working

Comments

@shakib-root
Copy link

Shouldn't sigmoid(multilabel classification) or softmax(multiclass classification) be applied here to get the predictions? Otherwise, later the thresholds are being applied on the logits directly.

preds = logits.detach().cpu().numpy()

@monologg monologg reopened this Jan 14, 2021
@monologg
Copy link
Owner

monologg commented Jan 14, 2021

@shakib-root

It's totally true that there is a mistake.

I'm fixing the issue on this branch (d47dfed) and re-running the models. As training is over, I'll reupload the model & result!

Thank you for informing the issue

@monologg monologg added the bug Something isn't working label Jan 14, 2021
@blackcat84
Copy link

Does this affect the already fine-tuned models (like the ones on the model hub of Hugging Face) or is it just a matter of metrics computation while fine-tuning?

@monologg
Copy link
Owner

@blackcat84

This one doesn't affect the fine-tuned models, but there might be a possibility that the model from huggingface model hub isn't the best model cuz I've chose the model based on the wrong metrics

@blackcat84
Copy link

Right, makes perfectly sense. Looking forward to your new results! Thanks!

@monologg
Copy link
Owner

monologg commented Jan 16, 2021

Fixed on b75f9d3 :)

Also huggingface s3 models are updated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants