Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put global functions into (write protected?) tables #205

Closed
trentgill opened this issue Oct 7, 2019 · 3 comments
Closed

Put global functions into (write protected?) tables #205

trentgill opened this issue Oct 7, 2019 · 3 comments

Comments

@trentgill
Copy link
Collaborator

time should be in util.time
tell should be crow.tell or util.tell

there's all the C functions (including those 2 above) in libCrow: https://github.com/monome/crow/blob/master/lib/lualink.c#L448

Plus all the functions that are defined in crowlib https://github.com/monome/crow/blob/master/lua/crowlib.lua

@trentgill trentgill added this to the 1.2 milestone Oct 7, 2019
@pq
Copy link
Contributor

pq commented Oct 7, 2019

lots of global write-protection discussion over on norns... maybe monome/norns#667 is useful?

@tehn
Copy link
Member

tehn commented Oct 7, 2019

luckily LVM reset happens all of the time with crow, which is good. no attempt to preserve LVM state across scripts.

only a handful of crow things need to be protected, and luckily they are few. would even be sufficient to get them into a table as suggested.

most overwrites will happen by accident, ie time = 3 since that is a common var

@trentgill trentgill modified the milestones: 1.0.1, 1.1.0 Oct 8, 2019
@trentgill trentgill removed this from the Minor (1.1) milestone Jun 22, 2020
@trentgill
Copy link
Collaborator Author

Closing as it's a non-issue in terms of user experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants