Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimeZoneInfo doesn't work #27

Closed
NattyNarwhal opened this issue Jul 5, 2018 · 3 comments
Closed

TimeZoneInfo doesn't work #27

NattyNarwhal opened this issue Jul 5, 2018 · 3 comments
Labels
area: BCL This issue affects the Mono class libraries os: aix This issue affects AIX os: i This issue affects i type: bug Something isn't working

Comments

@NattyNarwhal
Copy link
Member

  • AIX is simple - it just needs to be pointed to /usr/share/lib/zoneinfo instead of every other Unix's /usr/share/zoneinfo.

  • i is much trickier - it lacks zoneinfo entirely; setting TZ to an explicit value. System values can be found with WRKOBJ QSYS/*ALL *TIMZON or WRKTIMZON. Some ideas:

    • Generate a zoneinfo database from the system time zone values on the native side. This means no framework changes and system integration, but a program to generate values will need to be maintained.

    • Modify the framework to call into the ILE and convert time zone values there. Will require either ugly changes in the middle of normal code, or perhaps even our own framework profile if we have to keep adding these.

    • The nice thing about these two approaches is that they'll behave in line with the rest of the system, operating on the same values.

    • Ship a copy of zoneinfo with our builds and point the library to use that. Portable, but a bit hackish.

@NattyNarwhal NattyNarwhal added type: bug Something isn't working os: aix This issue affects AIX os: i This issue affects i labels Jul 5, 2018
@NattyNarwhal
Copy link
Member Author

I think the reasonable course of action would be to upstream a workable patch for AIX, (for the sake of CI) and for our builds, patch TimeZoneInfo.cs and bundle the IANA database and tools.

@NattyNarwhal NattyNarwhal added the area: BCL This issue affects the Mono class libraries label Jul 5, 2018
@NattyNarwhal
Copy link
Member Author

We now ship the IANA time zone database and a patch to point Mono to it. (We might upstream a modified version for the sake of CI on AIX.)

@NattyNarwhal
Copy link
Member Author

Filed an issue to see if we can deal with it more elegantly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: BCL This issue affects the Mono class libraries os: aix This issue affects AIX os: i This issue affects i type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant