Capistrano2のrole定義で :no_release => true オプションを利用できるように変更
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hirocaster
requested changes
Mar 3, 2017
| @@ -1,6 +1,7 @@ | |||
| class ServerSettings | |||
|
|
|||
| class HostCollection < Array | |||
| attr_reader :role_config | |||
There was a problem hiding this comment.
capistranoではpropertyという呼び方をしてるので、揃えた方がわかりやすそうですね。
https://github.com/capistrano/capistrano/blob/bf45cbafe5ef396933c81f334bdbc8c6d32a38c2/spec/integration/dsl_spec.rb#L37
lib/server_settings/capistrano.rb
Outdated
| @@ -8,7 +8,11 @@ def self.extend(configuration) | |||
| def load_servers(pattern) | |||
| ServerSettings.load_config_dir(pattern) | |||
| ServerSettings.each_role do |role, hosts| | |||
| role role.to_sym, *hosts.map(&:host) | |||
| if hosts.class == ::ServerSettings::HostCollection && hosts.role_config["%no_release"] | |||
There was a problem hiding this comment.
あとはactiveやprimaryぐらいしかないみたいです。
https://github.com/capistrano/capistrano/blob/bf45cbafe5ef396933c81f334bdbc8c6d32a38c2/spec/integration/dsl_spec.rb#L13
この3パターンで分岐して書くか現在のrole_configの値を全部展開してしまっても良いかなと思いました。
|
@hirocaster コメント二件に関して、対応したので再度reviewお願い致します |
hirocaster
reviewed
Mar 8, 2017
README.md
Outdated
| @@ -164,7 +164,13 @@ require 'server_settings/capistrano' | |||
|
|
|||
| load_servers("config/production/*.yaml") | |||
|
|
|||
| ``` | |||
|
|
|||
| When want to use `no_release` option, described as follow. | |||
There was a problem hiding this comment.
せっかく対応したので、primary, activeも記載してみてはどうでしょ?
|
README側も追記致しました |
hirocaster
approved these changes
Mar 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
下記のようにyaml記述することで、
role :memcached, '192.168.100.1", :no_release => trueという形で定義されるように変更