/
range-controller-spec.js
420 lines (348 loc) · 18 KB
/
range-controller-spec.js
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
var Montage = require("montage").Montage;
var RangeController = require("montage/core/range-controller").RangeController;
var Set = require("montage/collections/set");
describe("core/range-controller-spec", function () {
var rangeController;
beforeEach(function () {
rangeController = (new RangeController()).initWithContent([0, 1, 2]);
});
describe("selection", function () {
describe("constrained by uniqueness", function () {
it("TODO should not allow duplicates");
it("TODO should allow new item if duplicate deleted in same splice");
});
it("swap should select an object in case of for no-op when rangeController avoidsEmptySelection", function () {
//Save state
var avoidsEmptySelection = rangeController.avoidsEmptySelection;
var selection = rangeController.selection;
//Needed for spec
rangeController.avoidsEmptySelection = true;
var swapResult = rangeController.selection.swap(0,0,[]);
//set property to what it was
rangeController.avoidsEmptySelection = avoidsEmptySelection;
rangeController.selection = selection;
expect(swapResult.toArray()).toEqual([]);
expect(rangeController.selection.toArray()).toEqual([0]);
});
it("should allow setting selection to null/undefined", function () {
rangeController.selection = [1];
expect(rangeController.selection.length).toBe(1);
rangeController.selection = undefined;
expect(rangeController.selection.length).toBe(0);
rangeController.selection = [1];
expect(rangeController.selection.length).toBe(1);
rangeController.selection = null;
expect(rangeController.selection.length).toBe(0);
});
describe("constrained to content", function () {
it("should allow selection if subset of content", function () {
rangeController.selection.add(1);
expect(rangeController.selection.toArray()).toEqual([1]);
});
it("should disallow selection if not in content", function () {
rangeController.selection.add(5);
expect(rangeController.selection.toArray()).toEqual([]);
});
it("should remove selection if selected content is removed", function () {
rangeController.selection.add(2);
rangeController.pop();
expect(rangeController.selection.toArray()).toEqual([]);
});
it("should not remove selection if other content is removed", function () {
rangeController.selection.add(1);
rangeController.pop();
expect(rangeController.selection.toArray()).toEqual([1]);
});
it("should remove selection if selection is not in new content", function () {
rangeController.selection.add(2);
rangeController.content = [0, 1, 3];
expect(rangeController.selection.toArray()).toEqual([]);
});
it("should not remove selection if selection is in new content", function () {
rangeController.selection.add(1);
rangeController.content = [0, 1];
expect(rangeController.selection.toArray()).toEqual([1]);
});
});
describe("constrained by allowsMultipleSelection", function () {
beforeEach(function () {
rangeController.selection.add(0);
expect(rangeController.selection.toArray()).toEqual([0]);
});
describe("when false", function () {
beforeEach(function () {
rangeController.allowsMultipleSelection = false;
});
it("allows a selected item to be added", function () {
rangeController.selection.add(1);
expect(rangeController.selection.toArray()).toEqual([1]);
});
it("does not allow multiple selected items to be added", function () {
rangeController.selection.add(1)
rangeController.selection.add(2);
expect(rangeController.selection.toArray()).toEqual([2]);
});
it("TODO: test two-way bindings with multiple values");
it("allowsMultipleSelection splicing and setting", function () {
rangeController.selection.splice(1, 0, 2);
expect(rangeController.selection.toArray()).toEqual([2]);
rangeController.selection.splice(0, 1, 0, 1);
expect(rangeController.selection.toArray()).toEqual([1]);
});
it("results in correct calls to range change listeners", function () {
var spy = jasmine.createSpy();
rangeController.selection.addRangeChangeListener(spy);
rangeController.selection.add(2);
expect(spy).toHaveBeenCalled();
var args = spy.mostRecentCall.args;
expect(args[0]).toEqual([2]);
expect(args[1]).toEqual([0]);
expect(args[2]).toEqual(0);
});
it("correctly updates another RangeController's content", function () {
rangeController.selection.add(1);
expect(rangeController.selection.toArray()).toEqual([1]);
// from Repetition#content setter
var object = new RangeController().initWithContent(rangeController.selection);
expect(object.organizedContent.toArray()).toEqual([1]);
rangeController.selection.push(2);
expect(rangeController.selection.toArray()).toEqual([2]);
expect(object.organizedContent.toArray()).toEqual([2]);
});
});
describe("when true", function () {
beforeEach(function () {
rangeController.allowsMultipleSelection = true;
});
it("allows multiple selected items to be added", function () {
rangeController.selection.add(1);
rangeController.selection.add(2);
expect(rangeController.selection.toArray()).toEqual([0, 1, 2]);
});
it("allows multiple selected items to be set", function () {
rangeController.selection.splice(0, 1, 1, 2);
expect(rangeController.selection.toArray()).toEqual([1, 2]);
});
});
});
describe("constrained by avoidsEmptySelection", function () {
beforeEach(function () {
rangeController.allowsMultipleSelection = true;
rangeController.selection.splice(0, 0, 0, 1);
expect(rangeController.selection.toArray()).toEqual([0, 1]);
});
describe("when true", function () {
beforeEach(function () {
rangeController.avoidsEmptySelection = true;
});
it("allows a selected item to be removed", function () {
rangeController.selection.pop();
expect(rangeController.selection.toArray()).toEqual([0]);
});
it("does not allow selection to be cleared", function () {
rangeController.selection.clear();
expect(rangeController.selection.toArray()).toEqual([0]);
});
it("allows a selected item to be set", function () {
rangeController.selection.splice(0, 100, 1);
expect(rangeController.selection.toArray()).toEqual([1]);
});
it("does not allow splice to clear selection", function () {
rangeController.selection.splice(0, 100);
expect(rangeController.selection.toArray()).toEqual([0]);
});
it("does not have an empty selection when selected content is removed", function () {
rangeController.allowsMultipleSelection = false;
rangeController.selection = [0];
rangeController.content.delete(0);
expect(rangeController.selection.length).toBe(1);
expect(rangeController.selection.toArray()).not.toEqual([0]);
});
it("should contain last element of content, if it would be empty after content change", function () {
rangeController.multiSelect = false;
rangeController.selection = [2];
rangeController.content.delete(2);
expect(rangeController.selection.length).toBe(1);
expect(rangeController.selection.toArray()).toEqual([1]);
});
});
describe("when false", function () {
beforeEach(function () {
rangeController.avoidsEmptySelection = false;
});
it("allows selection to be cleared", function () {
rangeController.selection.clear();
expect(rangeController.selection.toArray()).toEqual([]);
});
it("allows splice to clear selection", function () {
rangeController.selection.splice(0, 100);
expect(rangeController.selection.toArray()).toEqual([]);
});
});
});
describe("constrained by selectAddedContent", function () {
beforeEach(function () {
rangeController.selectAddedContent = true;
});
describe("when true", function () {
it("should select added content", function () {
rangeController.selection.length = 0;
rangeController.add(3);
expect(rangeController.selection.toArray()).toEqual([3]);
});
it("should use swap to ensure selection isn't cleared then content added", function () {
rangeController.selection = [2];
rangeController.selection.addRangeChangeListener(function (plus, minus, i) {
expect(plus.length).not.toBe(0);
});
rangeController.add(3); // observed change of plus should be [3], not [] then [3]
});
});
});
describe("constrained to always have one selection", function () {
beforeEach(function () {
rangeController.avoidsEmptySelection = false;
rangeController.avoidsEmptySelection = true;
rangeController.selection.add(0);
expect(rangeController.selection.toArray()).toEqual([0]);
});
it("does not allow the selected item to be removed", function () {
rangeController.selection.pop();
expect(rangeController.selection.toArray()).toEqual([0]);
});
it("does not allow another selected item to be added", function () {
rangeController.selection.add(1);
expect(rangeController.selection.toArray()).toEqual([1]);
});
it("does not allow all selection to be cleared", function () {
rangeController.selection.clear();
expect(rangeController.selection.toArray()).toEqual([0]);
});
it("only allows one selected item to be set", function () {
rangeController.selection.splice(0, 0, 1, 2);
expect(rangeController.selection.toArray()).toEqual([2]);
});
it("does not allow no selected items to be set", function () {
rangeController.selection.splice(0, 100);
expect(rangeController.selection.toArray()).toEqual([0]);
});
});
describe("negative splice inputs", function () {
it("can be spliced with a negative start", function () {
rangeController.allowsMultipleSelection = true;
rangeController.selection = [0, 1, 2];
expect(rangeController.selection.toArray()).toEqual([0, 1, 2]);
var removed = rangeController.selection.splice(-1, 1);
expect(removed).toEqual([2]);
expect(rangeController.selection.toArray()).toEqual([0, 1]);
});
it("can be spliced with a negative start, and howMany more than length", function () {
rangeController.allowsMultipleSelection = true;
rangeController.avoidsEmptySelection = true;
rangeController.selection = [0, 1, 2];
expect(rangeController.selection.toArray()).toEqual([0, 1, 2]);
var removed = rangeController.selection.splice(-3, 5);
expect(removed).toEqual([1, 2]);
expect(rangeController.selection.toArray()).toEqual([0]);
});
});
});
xit("Test what happens if two selections are two-way bound and their owners have different settings. I assume total chaos.");
describe("addContent and contentConstructor", function () {
it("should instantiate a configured content type", function () {
rangeController.contentConstructor = function FromTheFirstDimension() {
this.x = 10;
};
var content = rangeController.addContent();
expect(content).toEqual({x: 10});
expect(rangeController.content).toContain({x: 10});
});
it("should defer to the content type of the backing collection", function () {
var content = [];
content.contentConstructor = function FromTheFirstDimension() {
this.x = 10;
};
rangeController.content = content;
var content = rangeController.addContent();
expect(content).toEqual({x: 10});
expect(rangeController.content).toContain({x: 10});
});
it("should use a default content constructor otherwise", function () {
var content = rangeController.addContent();
expect(content).toEqual({});
expect(rangeController.content).toContain({});
});
it("should use a default content constructor when no content is available", function () {
rangeController = new RangeController();
var content = rangeController.addContent();
expect(content).toEqual({});
expect(rangeController.content).toContain({});
});
it("should ensure homogeneous content type", function () {
rangeController.content = [];
rangeController.contentConstructor = Date;
rangeController.addContent();
rangeController.addContent();
rangeController.addContent();
expect(rangeController.content.every(function (date) {
return date instanceof rangeController.contentConstructor;
})).toBe(true);
});
});
describe("When content has a custom contentEquals", function () {
beforeEach(function () {
var content = [0, 1, 2];
content.contentEquals = function (){ return true; };
expect(content.find(42)).toBe(0);
rangeController = (new RangeController()).initWithContent(content);
rangeController.allowsMultipleSelection = true;
rangeController.selection = [0];
expect(rangeController.selection.toArray()).toEqual([0]);
});
it("should not allow duplicates according to the custom contentEquals", function () {
rangeController.selection.add(1);
expect(rangeController.selection.toArray()).toEqual([0]);
});
it("should check of selection is in content using the custom contentEquals", function () {
rangeController.selection.splice(0, 1, 42);
expect(rangeController.selection.toArray()).toEqual([42]);
});
});
describe("swap", function () {
it("should accept an array of added items, rather than being variadic.", function () {
rangeController.content = [1, 2];
rangeController.swap(1, 1, [3, 4]);
expect(rangeController.content).toEqual([1, 3, 4]);
});
});
describe("filtering, sorting and reversing", function () {
it("filterPath should work as expected", function () {
rangeController.content = [1, 2, 3, 4, 5];
rangeController.filterPath = "%2";
expect(rangeController.organizedContent).toEqual([1, 3, 5]);
rangeController.content = [1, 2, 3];
expect(rangeController.organizedContent).toEqual([1, 3]);
});
it("sortPath should work as expected", function () {
rangeController.content = [3, 1, 5, 2, 4];
rangeController.sortPath = "";
expect(rangeController.organizedContent).toEqual([1, 2, 3, 4, 5]);
rangeController.content = [2, 3, 1];
expect(rangeController.organizedContent).toEqual([1, 2, 3]);
});
it("reversed should work as expected", function () {
rangeController.content = [1, 2, 3, 4, 5];
rangeController.reversed = true;
expect(rangeController.organizedContent).toEqual([5, 4, 3, 2, 1]);
rangeController.content = [1, 2, 3];
expect(rangeController.organizedContent).toEqual([3, 2, 1]);
});
it("together should work as expected", function () {
rangeController.content = [3, 1, 5, 2, 4];
rangeController.filterPath = "%2";
rangeController.sortPath = "";
rangeController.reversed = true;
expect(rangeController.organizedContent).toEqual([5, 3, 1]);
});
});
});