fix percentile return error when only one element #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kvaz1r
reviewed
Jul 9, 2019
percentile.go
Outdated
| @@ -18,6 +18,10 @@ func Percentile(input Float64Data, percent float64) (percentile float64, err err | |||
| // Start by sorting a copy of the slice | |||
| c := sortedCopy(input) | |||
|
|
|||
| if len(c) == 1 { | |||
There was a problem hiding this comment.
It's really micro optimization but maybe better move this check before sorting?
There was a problem hiding this comment.
It's really micro optimization but maybe better move this check before sorting?
done
shiyan2016
force-pushed
the
fix-percentile
branch
from
e227dd2
to
f8c3d9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #46