Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stable sampling #48

Merged
merged 1 commit into from
Aug 16, 2019
Merged

add stable sampling #48

merged 1 commit into from
Aug 16, 2019

Conversation

xiaobogaga
Copy link
Contributor

@xiaobogaga xiaobogaga commented Aug 16, 2019

It turns out current sample function doesn't return the data as original order, it would shuffle the previous data. So here I provide a stableSample method, it samples the data and keep the order as well. Sometimes I found when I want use the sample, but also I would like keep the original order to see its trends.

PTAL thanks.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 496928c on xiaobogaga:add_stable_sample into dfab42c on montanaflynn:master.

@montanaflynn
Copy link
Owner

Looks great, thanks a lot!

@montanaflynn montanaflynn merged commit ce31985 into montanaflynn:master Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants