Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URL validator bug #221

Merged
merged 2 commits into from Dec 6, 2017
Merged

Fix URL validator bug #221

merged 2 commits into from Dec 6, 2017

Conversation

JacobBennett
Copy link
Contributor

Fixes #220

@codecov-io
Copy link

codecov-io commented Nov 22, 2017

Codecov Report

Merging #221 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #221   +/-   ##
=======================================
  Coverage   99.54%   99.54%           
=======================================
  Files          24       24           
  Lines         438      438           
=======================================
  Hits          436      436           
  Misses          2        2
Impacted Files Coverage Δ
src/validators/url.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8448738...64e873f. Read the comment docs.

@Frizi
Copy link
Contributor

Frizi commented Nov 22, 2017

I don't think case insensitve regex is a good idea. Mixed casing in protocols is one reason. See comments on #220 for details. This fix will also need some test coverage for sure.

@JacobBennett
Copy link
Contributor Author

Updated #220 with additional details.

@Frizi
Copy link
Contributor

Frizi commented Nov 23, 2017

I'm convinced it's a good solution. The only missing part is some tests. If you can add at least one upper case and mixed case scenario, that would be perfect.

@Frizi
Copy link
Contributor

Frizi commented Dec 6, 2017

Looks perfect, thanks!

@Frizi Frizi merged commit b65cbf4 into vuelidate:master Dec 6, 2017
@JacobBennett JacobBennett deleted the patch-1 branch December 6, 2017 20:10
@JacobBennett
Copy link
Contributor Author

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants